| Summary: | REGRESSION (r82144): Icon overlaps text in Twitter message dialog | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||
| Component: | Layout and Rendering | Assignee: | mitz | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ademar, dglazkov, webkit.review.bot | ||||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
mitz
2011-05-21 13:37:45 PDT
<rdar://problem/9479926> Reduction: X <img style="position: absolute;" src="#"> Y Created attachment 94327 [details]
Add midpoints for positioned objects when adding a midpoint behind the current character
Comment on attachment 94327 [details] Add midpoints for positioned objects when adding a midpoint behind the current character Attachment 94327 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8722507 New failing tests: fast/block/positioning/058.html Created attachment 94329 [details]
Archive of layout-test-results from ec2-cr-linux-03
The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 94327 [details] Add midpoints for positioned objects when adding a midpoint behind the current character View in context: https://bugs.webkit.org/attachment.cgi?id=94327&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:1777 > +void TrailingObjects::updateMidpointsForTrailingBoxes(LineMidpointState& lineMidpointState, const InlineIterator& lBreak, bool mergeWithLineBreak) Both call sites are passing constants, and the false and true at the call sites are completely opaque, so this is one of those cases where an enum would make things clearer than a bool. Fixed in r87026. <http://trac.webkit.org/changeset/87026> Revision r87026 cherry-picked into qtwebkit-2.2 with commit c4e7010 <http://gitorious.org/webkit/qtwebkit/commit/c4e7010> |