Bug 61238

Summary: Share more code in PathTraversalState
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zimmermann: review+

Description Dirk Schulze 2011-05-20 22:56:19 PDT 
Share more code in PathTraversalState.
Comment 1 Dirk Schulze 2011-05-20 23:31:37 PDT 
Created attachment 94322 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-05-20 23:34:40 PDT 
Comment on attachment 94322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94322&action=review

Looks good, r=me.

> Source/WebCore/platform/graphics/PathTraversalState.cpp:209
> +    if (m_action == TraversalSegmentAtLength
> +        && m_totalLength >= m_desiredLength)

No need to wrap the line here, eh?

> Source/WebCore/platform/graphics/PathTraversalState.cpp:214
> +    if ((m_action == TraversalPointAtLength
> +        || m_action == TraversalNormalAngleAtLength)
> +        && m_totalLength >= m_desiredLength) {

Ditto?

> Source/WebCore/platform/graphics/PathTraversalState.h:50
> +    void finalizeSegmentCalculation();

How about "processSegment" ?
Comment 3 Dirk Schulze 2011-05-20 23:44:24 PDT 
Committed r87011: <http://trac.webkit.org/changeset/87011>