Bug 61226

Summary: AudioBufferSourceNode noteOff() method must respect scheduling time
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Rogers
Reported 2011-05-20 16:49:53 PDT
AudioBufferSourceNode noteOff() method must respect scheduling time
Attachments
Patch (6.96 KB, patch)
2011-05-20 17:09 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-05-20 17:09:46 PDT
Created attachment 94296 [details] Patch
Kenneth Russell
Comment 2 2011-05-20 17:59:14 PDT
Comment on attachment 94296 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94296&action=review Looks fine. One comment about testing. > Source/WebCore/ChangeLog:8 > + No new tests since audio API is not yet implemented. Now that you have a mechanism for rendering to a buffer, would it make sense to start writing layout tests?
Chris Rogers
Comment 3 2011-05-20 19:18:06 PDT
Hi Ken, I'm still working with Dirk Pranke (currently on vacation) to get everything landed in ORWT and NWRT so I can get the layout tests going.
WebKit Commit Bot
Comment 4 2011-05-21 02:42:21 PDT
Comment on attachment 94296 [details] Patch Clearing flags on attachment: 94296 Committed r87013: <http://trac.webkit.org/changeset/87013>
WebKit Commit Bot
Comment 5 2011-05-21 02:42:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.