| Summary: | [Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joe Wild <joseph.wild> |
| Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ademar, commit-queue, joel.parks, laszlo.gombos, webkit.review.bot |
| Priority: | P3 | Keywords: | Qt |
| Version: | 528+ (Nightly build) | ||
| Hardware: | S60 Hardware | ||
| OS: | S60 3rd edition | ||
| Attachments: | |||
|
Description
Joe Wild
2011-05-20 11:16:47 PDT
Created attachment 94246 [details]
Updated Qt Webkit Symbian .def file to allow Symibian to build
Comment on attachment 94246 [details] Updated Qt Webkit Symbian .def file to allow Symibian to build Clearing flags on attachment: 94246 Committed r87060: <http://trac.webkit.org/changeset/87060> All reviewed patches have been landed. Closing bug. Revision r87060 cherry-picked into qtwebkit-2.2 with commit 8385385 <http://gitorious.org/webkit/qtwebkit/commit/8385385> Note: - This bug/commit is to follow-up on this change http://trac.webkit.org/changeset/80319 This commit break compatibility with the 2.1 QtWebKit release as it changes the mapping of already released ordinal numbers to symbols. This bug needs to be reopened (I do not seem to have privileges to do that). reopening Created attachment 98354 [details] Revert r87060 as it broke compatibility with QtWebKit 2.1 release Created attachment 98390 [details] Revert r87060 as it broke compatibility with QtWebKit 2.1 release Some minor cleanup. Comment on attachment 98390 [details] Revert r87060 as it broke compatibility with QtWebKit 2.1 release r=me. Comment on attachment 98390 [details] Revert r87060 as it broke compatibility with QtWebKit 2.1 release Clearing flags on attachment: 98390 Committed r89621: <http://trac.webkit.org/changeset/89621> All reviewed patches have been landed. Closing bug. Revision r89621 cherry-picked into qtwebkit-2.2 with commit 50b8e14 <http://gitorious.org/webkit/qtwebkit/commit/50b8e14> Created attachment 99468 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build
(In reply to comment #14) > Created an attachment (id=99468) [details] > Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build This bug is RESOLVED/FIXED, so should it be reopen? (I assume that the previous patch just reverted the change and this one is fixing it for real, is that right?) Please reopen if that's the case. Reopen to add more symbols on top of the previously landed patch. Comment on attachment 99468 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build
LGTM (for both trunk and 2.2 branch).
Comment on attachment 99468 [details] Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 on Symibian to build Clearing flags on attachment: 99468 Committed r90227: <http://trac.webkit.org/changeset/90227> All reviewed patches have been landed. Closing bug. (In reply to comment #17) > (From update of attachment 99468 [details]) > LGTM (for both trunk and 2.2 branch). so I am adding blocks 55055 Revision r90227 cherry-picked into qtwebkit-2.2 with commit 2b44c16 <http://gitorious.org/webkit/qtwebkit/commit/2b44c16> Reopen as QtWebKit now builds for Symbian but the Tools directory is failing because some symbols are still not exported that are needed for Tools. :-) Created attachment 99511 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build
Comment on attachment 99511 [details]
Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build
great, thanks !
Comment on attachment 99511 [details] Updated Qt Webkit Symbian .def file to allow QtWebKit2.2 Tools directory on Symibian to build Clearing flags on attachment: 99511 Committed r90276: <http://trac.webkit.org/changeset/90276> All reviewed patches have been landed. Closing bug. Revision r90276 cherry-picked into qtwebkit-2.2 with commit e3377c0 <http://gitorious.org/webkit/qtwebkit/commit/e3377c0> |