Bug 61187

Summary: [Qt][V8] Enable ScriptController::disableEval functionality in QtWebkit-V8 build
Product: WebKit Reporter: Peter Varga <pvarga>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, hausmann, jedrzej.nowacki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Peter Varga
Reported 2011-05-20 06:33:41 PDT
This functionality has been disabled in QtWebkit-V8 build because qtscript-staging's shipped version of V8's API doesn't provide the Context::AllowCodeGenerationFromStrings() method yet. It is in V8 since http://code.google.com/p/v8/source/detail?r=7753 This functionality will be enabled at the next update of the qtscript-staging's V8 fork.
Attachments
proposed patch (1.88 KB, patch)
2011-06-21 07:58 PDT, Peter Varga 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Varga
Comment 1 2011-06-21 07:58:54 PDT
Created attachment 97989 [details] proposed patch The QtScript's V8 is up-to-date now. We can enable this functionality.
Andreas Kling
Comment 2 2011-06-21 08:18:12 PDT
Comment on attachment 97989 [details] proposed patch rs=me
WebKit Review Bot
Comment 3 2011-06-21 09:00:18 PDT
Comment on attachment 97989 [details] proposed patch Clearing flags on attachment: 97989 Committed r89359: <http://trac.webkit.org/changeset/89359>
WebKit Review Bot
Comment 4 2011-06-21 09:00:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.