Bug 61172

Summary: Fix style errors in DumpRenderTree/chromium/
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Trivial CC: morrita
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2011-05-20 01:08:07 PDT
Fix style errors in DumpRenderTree/chromium/
Attachments
Patch (62.79 KB, patch)
2011-05-20 01:09 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-05-20 01:09:29 PDT
Created attachment 94186 [details] Patch
Ryosuke Niwa
Comment 2 2011-05-20 01:41:23 PDT
Comment on attachment 94186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94186&action=review > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:263 > + // It may have references to not-yet-cleaned up windows. By cleaning up > + // here we help purify reports. It seems like we can fit all of these two lines in one line.
Kent Tamura
Comment 3 2011-05-20 01:46:38 PDT
Comment on attachment 94186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94186&action=review Thank you for reviewing. >> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:263 >> + // here we help purify reports. > > It seems like we can fit all of these two lines in one line. Yes. But I don't like a looong comment line.
Kent Tamura
Comment 4 2011-05-20 01:48:24 PDT
Comment on attachment 94186 [details] Patch Clearing flags on attachment: 94186 Committed r86930: <http://trac.webkit.org/changeset/86930>
Kent Tamura
Comment 5 2011-05-20 01:48:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.