Bug 61171

Summary:

Apply the ParallelJobs support to FEConvolveMatrix

Product:

WebKit

Reporter:

Andras Piroska <pandras>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

loki, ossy, zherczeg, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Apply the ParallelJobs support to FEConvolveMatrix	zimmermann: review+

Description Andras Piroska 2011-05-20 00:42:48 PDT

The FEConvolveMatrix filter of SVG can consume lots of resources if it is
applied to a large area. The computation can be distributed to multiple
cores if the architecture supports.
The average performance progression is 20-30% on dual-core machines.

Comment 1 Andras Piroska 2011-05-20 01:05:29 PDT

Created attachment 94185 [details]
Apply the ParallelJobs support to FEConvolveMatrix

Comment 2 Nikolas Zimmermann 2011-05-20 01:27:11 PDT

Comment on attachment 94185 [details]
Apply the ParallelJobs support to FEConvolveMatrix

View in context: https://bugs.webkit.org/attachment.cgi?id=94185&action=review

Looks great, r=me.

> Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp:258
> +    for (int y = yEnd + 1; y>yStart; --y) {
>          for (int x = clipRight + 1; x > 0; --x) {

Style: y > yStart, please.

Comment 3 Gabor Loki 2011-05-20 01:54:39 PDT

Landed in http://trac.webkit.org/changeset/86931