Summary: | [chromium] Fix division by zero in TilingData for boundary case texture sizes | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||
Component: | New Bugs | Assignee: | Adrienne Walker <enne> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, enne, jamesr, scheib | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Adrienne Walker
2011-05-19 19:03:23 PDT
Created attachment 94157 [details]
Patch
This fixes this crasher: http://crash/reportdetail?reportid=139f0688bc41a480 The new test cases repro the division by zero without the corresponding code fix. Comment on attachment 94157 [details]
Patch
Do you know how to repro this with a web page?
(In reply to comment #3) > (From update of attachment 94157 [details]) > Do you know how to repro this with a web page? I suspect that any composited 2xY layer would cause this issue, where Y <= 512. ContentLayerChromium would set the tile size to be 2x2 because it's small and would ask for border texels in the tiler because it's on a transformed layer. TilingData's computeNumTiles properly handles this case and avoids the division by zero, but tileXIndexFromSrcCoord does not. Comment on attachment 94157 [details]
Patch
LGTM
Comment on attachment 94157 [details] Patch Clearing flags on attachment: 94157 Committed r87094: <http://trac.webkit.org/changeset/87094> All reviewed patches have been landed. Closing bug. |