Bug 61163

Summary: Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position
Product: WebKit Reporter: Naoki Takano <honten>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, florian_schwab, honten, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
tkent: review+
Change summary none

Description Naoki Takano 2011-05-19 18:30:55 PDT
Number input should handle cursor position intelligently when it formats the value.
Comment 1 Naoki Takano 2011-05-19 18:34:34 PDT
Created attachment 94156 [details]
Patch
Comment 2 Naoki Takano 2011-05-19 18:35:32 PDT
Comment on attachment 94156 [details]
Patch

Please review.
Comment 3 Kent Tamura 2011-05-19 22:26:33 PDT
Comment on attachment 94156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94156&action=review

> Source/WebCore/ChangeLog:5
> +        Number input should handle cursor position intelligently when it formats the value.

The summary is not concrete. It should be something like "Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position"
Comment 4 Naoki Takano 2011-05-19 22:48:37 PDT
Created attachment 94177 [details]
Change summary

webkit-patch script doesn't work well suddenly in my environment...

So manually I made the patch.

I just change the summary.

Please review and commit.

Thanks,
Comment 5 WebKit Commit Bot 2011-05-19 23:37:14 PDT
Comment on attachment 94177 [details]
Change summary

Clearing flags on attachment: 94177

Committed r86926: <http://trac.webkit.org/changeset/86926>
Comment 6 WebKit Commit Bot 2011-05-19 23:37:19 PDT
All reviewed patches have been landed.  Closing bug.