Bug 61163 - Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position
Summary: Fix a problem that updating HTMLInputElement::value sets the cursor to a wron...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-19 18:30 PDT by Naoki Takano
Modified: 2015-12-04 03:33 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2011-05-19 18:34 PDT, Naoki Takano 		tkent: review+
Details | Formatted Diff | Diff
Change summary (2.36 KB, patch)
2011-05-19 22:48 PDT, Naoki Takano 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Naoki Takano 2011-05-19 18:30:55 PDT 
Number input should handle cursor position intelligently when it formats the value.
Comment 1 Naoki Takano 2011-05-19 18:34:34 PDT 
Created attachment 94156 [details]
Patch
Comment 2 Naoki Takano 2011-05-19 18:35:32 PDT 
Comment on attachment 94156 [details]
Patch

Please review.
Comment 3 Kent Tamura 2011-05-19 22:26:33 PDT 
Comment on attachment 94156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94156&action=review

> Source/WebCore/ChangeLog:5
> +        Number input should handle cursor position intelligently when it formats the value.

The summary is not concrete. It should be something like "Fix a problem that updating HTMLInputElement::value sets the cursor to a wrong position"
Comment 4 Naoki Takano 2011-05-19 22:48:37 PDT 
Created attachment 94177 [details]
Change summary

webkit-patch script doesn't work well suddenly in my environment...

So manually I made the patch.

I just change the summary.

Please review and commit.

Thanks,
Comment 5 WebKit Commit Bot 2011-05-19 23:37:14 PDT 
Comment on attachment 94177 [details]
Change summary

Clearing flags on attachment: 94177

Committed r86926: <http://trac.webkit.org/changeset/86926>
Comment 6 WebKit Commit Bot 2011-05-19 23:37:19 PDT 
All reviewed patches have been landed.  Closing bug.