| Summary: | Change RenderBlock hit testing to use IntPoint instead x,y pair | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
| Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, commit-queue, eric, leviw, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 60318 | ||||||||
| Attachments: |
|
||||||||
|
Description
Emil A Eklund
2011-05-19 14:39:41 PDT
Created attachment 94120 [details]
Patch
Comment on attachment 94120 [details]
Patch
Ok
Comment on attachment 94120 [details] Patch Rejecting attachment 94120 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: p Hunk #2 succeeded at 3909 with fuzz 1. Hunk #7 FAILED at 4014. 1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej patching file Source/WebCore/rendering/RenderBlock.h Hunk #1 succeeded at 584 (offset 11 lines). patching file Source/WebCore/rendering/RenderListBox.cpp patching file Source/WebCore/rendering/RenderListBox.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8716909 Created attachment 94454 [details]
Patch for landing
Comment on attachment 94454 [details] Patch for landing Clearing flags on attachment: 94454 Committed r87101: <http://trac.webkit.org/changeset/87101> All reviewed patches have been landed. Closing bug. |