Bug 61146

Summary: Change RenderBlock hit testing to use IntPoint instead x,y pair
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Severity: Normal CC: ap, commit-queue, eric, leviw, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 60318    
Description Flags
Patch for landing none

Description Emil A Eklund 2011-05-19 14:39:41 PDT
Change the hit testing code in RenderBlock to take an IntPoint instead of a pair of ints for the x,y position.
Comment 1 Emil A Eklund 2011-05-19 14:45:30 PDT
Created attachment 94120 [details]
Comment 2 Eric Seidel (no email) 2011-05-21 06:53:58 PDT
Comment on attachment 94120 [details]

Comment 3 WebKit Commit Bot 2011-05-21 06:55:52 PDT
Comment on attachment 94120 [details]

Rejecting attachment 94120 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
Hunk #2 succeeded at 3909 with fuzz 1.
Hunk #7 FAILED at 4014.
1 out of 8 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej
patching file Source/WebCore/rendering/RenderBlock.h
Hunk #1 succeeded at 584 (offset 11 lines).
patching file Source/WebCore/rendering/RenderListBox.cpp
patching file Source/WebCore/rendering/RenderListBox.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8716909
Comment 4 Emil A Eklund 2011-05-23 12:16:35 PDT
Created attachment 94454 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2011-05-23 15:15:30 PDT
Comment on attachment 94454 [details]
Patch for landing

Clearing flags on attachment: 94454

Committed r87101: <http://trac.webkit.org/changeset/87101>
Comment 6 WebKit Commit Bot 2011-05-23 15:15:35 PDT
All reviewed patches have been landed.  Closing bug.