Bug 61118

Summary:	[GTK] fullscreen/full-screen-keyboard-enabled.html fails
Product:	WebKit	Reporter:	Philippe Normand <pnormand>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	csaavedra, mrobinson, zan
Priority:	P2	Keywords:	Gtk, LayoutTestFailure
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Philippe Normand

Reported 2011-05-19 03:17:36 PDT

Because our ChromeClient always prohibits enterFullscreen for keyboard events. See http://trac.webkit.org/changeset/82124/trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp On mac the UIDelegate used by DRT always allows fullscreen, that's why the test passes there. We should do something similar on GTK, allow DRT to override this specific ChromeClient behavior. Will skip the test on GTK for now.

Attachments
Add attachment proposed patch, testcase, etc.

Philippe Normand

Comment 1 2012-06-15 13:05:31 PDT

A simpler solution would be to always allow enterFullscreen.

Martin Robinson

Comment 2 2015-05-07 17:46:26 PDT

Seems okay now.

Note You need to log in before you can comment on or make changes to this bug.