Bug 61076

Summary: Teach platform/win about window.internals
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, dglazkov, dominicc, jeffm, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 60313    
Bug Blocks: 61073    
Attachments:
Description Flags
Patch
none
Fixes tabs in WebKit2.def. dglazkov: review+

WebKit Review Bot
Reported 2011-05-18 10:11:31 PDT
Teach platform/win about window.internals Requested by dglazkov on #webkit.
Attachments
Patch (31.68 KB, patch)
2011-06-04 04:36 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Fixes tabs in WebKit2.def. (31.72 KB, patch)
2011-06-04 04:41 PDT, Dominic Cooney 		dglazkov: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-06-02 14:57:50 PDT
Now that bug 60313 is fixed, this is ripe for adding on Win! :)
Dimitri Glazkov (Google)
Comment 2 2011-06-02 16:03:16 PDT
I was told that Jeff Miller is a total hero who can fix this.
Jeff Miller
Comment 3 2011-06-02 16:26:23 PDT
(In reply to comment #2) > I was told that Jeff Miller is a total hero who can fix this. Maybe, but I'm completely unfamiliar with what this feature is.
Dominic Cooney
Comment 4 2011-06-04 04:36:29 PDT
Created attachment 96017 [details] Patch
Dominic Cooney
Comment 5 2011-06-04 04:41:09 PDT
Created attachment 96018 [details] Fixes tabs in WebKit2.def.
Dimitri Glazkov (Google)
Comment 6 2011-06-04 07:38:57 PDT
Comment on attachment 96018 [details] Fixes tabs in WebKit2.def. View in context: https://bugs.webkit.org/attachment.cgi?id=96018&action=review Yay Dominic!! Adam, Jeff, Jer -- does this look sane to you? > Source/WebKit2/win/WebKit2.def:140 > + ; Re-exports from WebCore for WebCoreTestSupport > + ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z > + ?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z > + ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ This seems troubling. I didn't realize we'd have to do this for Windows too :( I wonder if a "safely-export-symbol-across-platform" tool is in the cards for us.
Jer Noble
Comment 7 2011-06-04 09:55:17 PDT
Looks sane enough for me.
Dominic Cooney
Comment 8 2011-06-06 05:35:47 PDT
Committed r88159: <http://trac.webkit.org/changeset/88159>
Note You need to log in before you can comment on or make changes to this bug.