| Summary: | Teach platform/win about window.internals | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||||
| Component: | Tools / Tests | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aroben, dglazkov, dominicc, jeffm, jer.noble | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 60313 | ||||||||
| Bug Blocks: | 61073 | ||||||||
| Attachments: |
|
||||||||
|
Description
WebKit Review Bot
2011-05-18 10:11:31 PDT
Now that bug 60313 is fixed, this is ripe for adding on Win! :) I was told that Jeff Miller is a total hero who can fix this. (In reply to comment #2) > I was told that Jeff Miller is a total hero who can fix this. Maybe, but I'm completely unfamiliar with what this feature is. Created attachment 96017 [details]
Patch
Created attachment 96018 [details]
Fixes tabs in WebKit2.def.
Comment on attachment 96018 [details] Fixes tabs in WebKit2.def. View in context: https://bugs.webkit.org/attachment.cgi?id=96018&action=review Yay Dominic!! Adam, Jeff, Jer -- does this look sane to you? > Source/WebKit2/win/WebKit2.def:140 > + ; Re-exports from WebCore for WebCoreTestSupport > + ?getCachedDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PBUClassInfo@3@@Z > + ?cacheDOMStructure@WebCore@@YAPAVStructure@JSC@@PAVJSDOMGlobalObject@1@PAV23@PBUClassInfo@3@@Z > + ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ This seems troubling. I didn't realize we'd have to do this for Windows too :( I wonder if a "safely-export-symbol-across-platform" tool is in the cards for us. Looks sane enough for me. Committed r88159: <http://trac.webkit.org/changeset/88159> |