Bug 61072

Summary: When checking whether the tree is red, the EWS posts a link to the wrong log
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
needs tests
none
Patch none

Description WebKit Review Bot 2011-05-18 09:59:49 PDT
When checking whether the tree is red, the EWS posts a link to the wrong log
Requested by abarth on #webkit.
Comment 1 Eric Seidel (no email) 2011-05-27 16:56:56 PDT
Really?  Crazy.
Comment 2 Adam Barth 2011-05-27 16:58:59 PDT
Created attachment 95231 [details]
needs tests
Comment 3 Adam Barth 2011-05-27 17:02:38 PDT
This is a great example of "if its not tested, its broken".  We test that the right type of exception is thrown, but not which of the two possible exceptions of that type it is!
Comment 4 Adam Barth 2011-05-27 17:07:46 PDT
We want assertRaisesRegexp, but that doesn't exist until Python 2.7.  :(
Comment 5 Adam Barth 2011-05-27 17:20:20 PDT
Created attachment 95234 [details]
Patch
Comment 6 Eric Seidel (no email) 2011-05-27 18:09:25 PDT
Comment on attachment 95234 [details]
Patch

OK.
Comment 7 WebKit Commit Bot 2011-05-27 21:48:43 PDT
Comment on attachment 95234 [details]
Patch

Clearing flags on attachment: 95234

Committed r87601: <http://trac.webkit.org/changeset/87601>
Comment 8 WebKit Commit Bot 2011-05-27 21:48:48 PDT
All reviewed patches have been landed.  Closing bug.