Summary: | When checking whether the tree is red, the EWS posts a link to the wrong log | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Review Bot <webkit.review.bot> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, aroben, commit-queue, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
WebKit Review Bot
2011-05-18 09:59:49 PDT
Really? Crazy. Created attachment 95231 [details]
needs tests
This is a great example of "if its not tested, its broken". We test that the right type of exception is thrown, but not which of the two possible exceptions of that type it is! We want assertRaisesRegexp, but that doesn't exist until Python 2.7. :( Created attachment 95234 [details]
Patch
Comment on attachment 95234 [details]
Patch
OK.
Comment on attachment 95234 [details] Patch Clearing flags on attachment: 95234 Committed r87601: <http://trac.webkit.org/changeset/87601> All reviewed patches have been landed. Closing bug. |