Bug 61026

Summary:

Don't use DEFINE_STATIC_LOCAL with an unsigned

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

New Bugs

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

psolanki, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Pratik Solanki

Reported 2011-05-18 00:28:23 PDT

StorageTracker.cpp has DEFINE_STATIC_LOCAL(const unsigned, fileExtLength, (fileExt.length())); DEFINE_STATIC_LOCAL is meant for objects, not unsigned ints. We can just use static here.

Attachments
Patch (1.47 KB, patch) 2011-05-18 00:32 PDT, Pratik Solanki	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pratik Solanki

Comment 1 2011-05-18 00:32:33 PDT

Created attachment 93879 [details] Patch

Simon Fraser (smfr)

Comment 2 2011-05-18 07:55:02 PDT

I wonder if we could make it compile error to use DEFINE_STATIC_LOCAL on POD types?

Pratik Solanki

Comment 3 2011-05-18 09:13:16 PDT

Committed r86772: <http://trac.webkit.org/changeset/86772>

Note You need to log in before you can comment on or make changes to this bug.