Summary: | valueMissing validity for select elements is lame when selecting a value by a key operation | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||||||
Component: | Forms | Assignee: | Kent Tamura <tkent> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dmikurube, morrita | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Kent Tamura
2011-05-17 21:00:32 PDT
Oh, I have found a way to reproduce this problem on Mac. Created attachment 93870 [details]
Patch
Comment on attachment 93870 [details]
Patch
Code looks fine. Can we test item selections using lookahead-search and accesskey? both reaches setSelectedIndex().
Created attachment 93882 [details]
Patch 2
Adding an accesskey test
(In reply to comment #3) > (From update of attachment 93870 [details]) > Code looks fine. Can we test item selections using lookahead-search and accesskey? both reaches setSelectedIndex(). I have added an accesskey test. The previous patch already had a test for lookahead search. Created attachment 93884 [details]
Patch 3
Remove unnecessary change
Comment on attachment 93884 [details]
Patch 3
Kent-san, thank you for adding tests!
Thank you for reviewing! Comment on attachment 93884 [details] Patch 3 Clearing flags on attachment: 93884 Committed r86744: <http://trac.webkit.org/changeset/86744> All reviewed patches have been landed. Closing bug. |