Bug 61018
| Summary: | EFL builder needs to pass "-i" to to create_hash_table script | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
| Component: | WebKit Misc. | Assignee: | Gyuyoung Kim <gyuyoung.kim> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | leandro, lucas.de.marchi |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Geoffrey Garen
Not doing so means the generated .lut.h files don't #include Lookup.h, so they don't build.
The EFL builder is currently broken because of this, but I'm not familiar enough with the system to fix it.
You can look at JavaScriptCore/GNUMakefile.am, JavaScriptCore/DerivedSources.make, or JavaScriptCore/DerivedSources.pro for an example.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Geoffrey Garen
Assigning to gyuyoung.kim@samsung.com and CC'ing leandro@profusion.mobi because they're listed as the builder owners.
Unfortunately, I've never worked with them on any WebKit code, so I'm not sure what the best way to get in touch with them is.
Gyuyoung Kim
Ok, I look into this problem.
Gyuyoung Kim
In order to include Lookup.h, "-i" argument should be passed to create-hash-table. So, I add the "-i" option when cmake invokes the create_hash_table.
http://trac.webkit.org/changeset/86740
Geoffrey Garen
Thanks!