| Summary: | Change RenderTextControl::hitInnerTextElement to use IntPoint | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||
| Component: | New Bugs | Assignee: | Emil A Eklund <eae> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric, leviw, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 60318 | ||||||||
| Attachments: |
|
||||||||
|
Description
Emil A Eklund
2011-05-17 16:25:06 PDT
Created attachment 93843 [details]
Patch
Comment on attachment 93843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93843&action=review > Source/WebCore/rendering/RenderTextControl.cpp:473 > + result.setLocalPoint(pointInContainer - IntSize(tx + x() + m_innerText->renderBox()->x(), > + ty + y() + m_innerText->renderBox()->y())); We shouldn’t line up like this. The style guide specifically says not to. > We shouldn’t line up like this. The style guide specifically says not to.
Will fix before I commit, thanks for pointing it out!
Created attachment 93987 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 93987 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 93987 [details] Patch for landing Clearing flags on attachment: 93987 Committed r86807: <http://trac.webkit.org/changeset/86807> All reviewed patches have been landed. Closing bug. It seems like some tests are failing on Leopard bots: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/30422 http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r86807%20(30422)/results.html before: http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r86806%20(30421)/results.html Those two tests appears to be flakey, they passed in the most recent build but failed the one before: http://build.webkit.org/builders/Leopard%20Intel%20Debug%20%28Tests%29/builds/30442/steps/layout-test/logs/stdio |