Bug 60979

Summary: SVGRootInlineBox triggers calculateBoundaries twice in layout
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leo.yang, leviw, zimmermann
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zimmermann: review+

Levi Weintraub
Reported 2011-05-17 12:35:37 PDT
Within computerPerCharacterLayoutInformation, first layoutChildBoxes is called. This function calls calculateBoundaries on all child boxes. Directly afterwards, layoutRootBox determines the rect for itself based on its children, but instead of using the values just calculated in the previous step, they're re-calculated. There is no early return in calculateBoundaries.
Attachments
Patch (6.56 KB, patch)
2011-05-20 00:23 PDT, Leo Yang 		zimmermann: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2011-05-20 00:23:24 PDT
Created attachment 94181 [details] Patch
Nikolas Zimmermann
Comment 2 2011-05-20 00:45:21 PDT
Comment on attachment 94181 [details] Patch Good catch, r=me, assuming no regressions.
Leo Yang
Comment 3 2011-05-20 00:57:21 PDT
Committed r86927: <http://trac.webkit.org/changeset/86927>
Note You need to log in before you can comment on or make changes to this bug.