Bug 60965

Summary: GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
Product: WebKit Reporter: Grace Kloba <klobag>
Component: WebGLAssignee: Grace Kloba <klobag>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Grace Kloba
Reported 2011-05-17 09:27:31 PDT
Currently Skia version of GraphicsContext3D always uses BGRA8 format as source. It should check SK_x_SHIFT.
Attachments
Patch (1.70 KB, patch)
2011-05-17 09:32 PDT, Grace Kloba 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grace Kloba
Comment 1 2011-05-17 09:32:41 PDT
Created attachment 93779 [details] Patch
Kenneth Russell
Comment 2 2011-05-17 09:47:18 PDT
Comment on attachment 93779 [details] Patch Looks good. Thanks for taking care of this.
WebKit Commit Bot
Comment 3 2011-05-17 10:13:22 PDT
Comment on attachment 93779 [details] Patch Clearing flags on attachment: 93779 Committed r86679: <http://trac.webkit.org/changeset/86679>
WebKit Commit Bot
Comment 4 2011-05-17 10:13:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.