Bug 60965 - GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of assuming BGRA color
Summary: GraphicsContext3DSkia needs to honor the platform Sk_x_SHIFT value instead of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Grace Kloba
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-17 09:27 PDT by Grace Kloba
Modified: 2011-05-17 10:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2011-05-17 09:32 PDT, Grace Kloba 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grace Kloba 2011-05-17 09:27:31 PDT 
Currently Skia version of GraphicsContext3D always uses BGRA8 format as source. It should check SK_x_SHIFT.
Comment 1 Grace Kloba 2011-05-17 09:32:41 PDT 
Created attachment 93779 [details]
Patch
Comment 2 Kenneth Russell 2011-05-17 09:47:18 PDT 
Comment on attachment 93779 [details]
Patch

Looks good. Thanks for taking care of this.
Comment 3 WebKit Commit Bot 2011-05-17 10:13:22 PDT 
Comment on attachment 93779 [details]
Patch

Clearing flags on attachment: 93779

Committed r86679: <http://trac.webkit.org/changeset/86679>
Comment 4 WebKit Commit Bot 2011-05-17 10:13:26 PDT 
All reviewed patches have been landed.  Closing bug.