Bug 60956

Summary: [Qt] Implement LayoutTestController::setValueForUser
Product: WebKit Reporter: Kristóf Kosztyó <kkristof>
Component: Tools / TestsAssignee: Kristóf Kosztyó <kkristof>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, luiz, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed fix
none
proposed fix none

Kristóf Kosztyó
Reported 2011-05-17 06:42:18 PDT
fast/forms/onchange-setvalueforuser.html is failed on Qt because the implement of layoutTestController.setValueForUser() is missing.
Attachments
proposed fix (5.61 KB, patch)
2011-05-17 06:48 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
proposed fix (5.67 KB, patch)
2011-05-17 08:15 PDT, Kristóf Kosztyó 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kristóf Kosztyó
Comment 1 2011-05-17 06:48:59 PDT
Created attachment 93761 [details] proposed fix
Andras Becsi
Comment 2 2011-05-17 07:09:47 PDT
Comment on attachment 93761 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=93761&action=review Besides one missing changelog line, the patch looks ok to me. Ossy will r+ it. Keep up the good work. > LayoutTests/ChangeLog:8 > + * platform/qt/Skipped: You should mention here which test you unskip, but this can be done before landing.
Kristóf Kosztyó
Comment 3 2011-05-17 08:15:59 PDT
Created attachment 93768 [details] proposed fix
Luiz Agostini
Comment 4 2011-05-17 12:27:21 PDT
Comment on attachment 93768 [details] proposed fix I am not an official reviewer but it LGTM.
Csaba Osztrogonác
Comment 5 2011-05-18 00:09:57 PDT
Great, r=me.
WebKit Commit Bot
Comment 6 2011-05-18 02:11:00 PDT
Comment on attachment 93768 [details] proposed fix Clearing flags on attachment: 93768 Committed r86742: <http://trac.webkit.org/changeset/86742>
WebKit Commit Bot
Comment 7 2011-05-18 02:11:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.