Bug 60937 – SunSpider: string-validate-input.js uses an undeclared variable named 'name', which is a DOM API

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Geoffrey Garen]

Here's the code:

      name = makeName(6);
      (k%2)?email=name+"@mac.com":email=name+"(at)mac.com";

Since 'name' is undeclared, and window.name defaults to the DOM frame name API, this test spends a bunch of time getting and setting the name of the frame in the DOM.

Of course we want the DOM to be fast, but testing the DOM seems contrary to the goals of SunSpider.

[Alexey Proskuryakov]

This is fixed in a r-'ed patch attached to bug 17634, although with a slightly different rationale.

[Geoffrey Garen]

It looks like Maciej planned to fix this, but never got around to it.

I think the important issue is to pick a name that doesn't conflict with a DOM API. Whether the variable is declared as a var or not is no big deal.

[Maciej Stachowiak]

Created attachment 99560 [details]
Patch

[Maciej Stachowiak]

Committed r90318: <http://trac.webkit.org/changeset/90318>