Bug 60926

Summary:

[chromium] shard V8DerivedSources into 19 files

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Tony Chang 2011-05-16 14:54:37 PDT

[chromium] shard V8DerivedSources into 20 files

Comment 1 Tony Chang 2011-05-16 15:08:18 PDT

Created attachment 93701 [details]
Patch

Comment 2 Tony Chang 2011-05-16 15:10:22 PDT

I also tested 20 files and 30 files, but both had slower files than with 19.  20 files had a file take 19s and 30 files had a file take 17s.  I suspect there's some benefit to using a value that's relatively prime to 8.

Comment 3 Adam Barth 2011-05-16 15:24:01 PDT

Comment on attachment 93701 [details]
Patch

OMG, thank you!

Comment 4 WebKit Commit Bot 2011-05-16 16:28:58 PDT

The commit-queue encountered the following flaky tests while processing attachment 93701 [details]:

http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com)
The commit-queue is continuing to process your patch.

Comment 5 WebKit Commit Bot 2011-05-16 16:32:49 PDT

Comment on attachment 93701 [details]
Patch

Clearing flags on attachment: 93701

Committed r86631: <http://trac.webkit.org/changeset/86631>

Comment 6 WebKit Commit Bot 2011-05-16 16:32:54 PDT

All reviewed patches have been landed.  Closing bug.