Bug 60925

Summary: Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, hyatt, leviw, mitz, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60113, 60729    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-05-16 14:51:22 PDT
Document why RenderBlockLineLayout has its own deleteLineBoxTree implementation
Attachments
Patch (3.01 KB, patch)
2011-05-16 14:53 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-05-16 14:53:25 PDT
Created attachment 93697 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-16 14:57:13 PDT
I tried to change this to deleteLineBoxTree in multiple different patches, and then was confused when things started crashing. I suspect that this code as-is is just papering over other bugs, but I'm leaving it as-is for now and documenting why it is that way.
Adam Barth
Comment 3 2011-05-16 15:09:22 PDT
Comment on attachment 93697 [details] Patch Ok...
WebKit Commit Bot
Comment 4 2011-05-16 16:11:01 PDT
Comment on attachment 93697 [details] Patch Clearing flags on attachment: 93697 Committed r86628: <http://trac.webkit.org/changeset/86628>
WebKit Commit Bot
Comment 5 2011-05-16 16:11:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.