| Summary: | Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Podivilov
2011-05-16 08:14:56 PDT
Created attachment 93645 [details]
Patch.
Comment on attachment 93645 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=93645&action=review > Source/WebCore/inspector/InspectorController.h:-118 > - void disableDebugger(); Please make sure this doesn't break Safari. I only see Start debugging... but please double check. > Source/WebCore/inspector/InspectorDebuggerAgent.cpp:144 > + m_inspectorState->setBoolean(DebuggerAgentState::debuggerEnabled, false); After front-end reopening debugger will be off in Safari. r- for this. (In reply to comment #2) > After front-end reopening debugger will be off in Safari. r- for this. Sorry, of cause it will be restored from the local store on the front-end and pushed to the back end. Comment on attachment 93645 [details] Patch. Attachment 93645 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8699878 Comment on attachment 93645 [details] Patch. Attachment 93645 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8704015 Committed r86581: <http://trac.webkit.org/changeset/86581> |