Bug 60888 – Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Podivilov]

Web Inspector: debuggerWasEnabled notification should not be send to frontend on navigation.

[Pavel Podivilov]

Created attachment 93645 [details]
Patch.

[Yury Semikhatsky]

Comment on attachment 93645 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=93645&action=review

> Source/WebCore/inspector/InspectorController.h:-118
> -    void disableDebugger();

Please make sure this doesn't break Safari. I only see Start debugging... but please double check.

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:144
> +    m_inspectorState->setBoolean(DebuggerAgentState::debuggerEnabled, false);

After front-end reopening debugger will be off in Safari. r- for this.

[Yury Semikhatsky]

(In reply to comment #2)
> After front-end reopening debugger will be off in Safari. r- for this.
Sorry, of cause it will be restored from the local store on the front-end and pushed to the back end.

[WebKit Review Bot]

Comment on attachment 93645 [details]
Patch.

Attachment 93645 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8699878

[Early Warning System Bot]

Comment on attachment 93645 [details]
Patch.

Attachment 93645 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8704015

[Pavel Podivilov]

Committed r86581: <http://trac.webkit.org/changeset/86581>