Summary: | [Qt][Wk2][Symbian] Fix build after r86560 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Siddharth Mathur <s.mathur> | ||||||
Component: | WebKit2 | Assignee: | Siddharth Mathur <s.mathur> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ossy | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Siddharth Mathur
2011-05-16 08:09:09 PDT
Created attachment 93644 [details] build fix for Symbian buildbot Fixes build failure: http://build.webkit.sed.hu/builders/Qt%20Symbian%20ARMv5%20Release/builds/1044/steps/compile%20Source/logs/stdio Comment on attachment 93644 [details] build fix for Symbian buildbot View in context: https://bugs.webkit.org/attachment.cgi?id=93644&action=review > Source/WebKit2/ChangeLog:10 > + (CoreIPC::ArgumentDecoder::~ArgumentDecoder): guard Unix and Gtk code with HAVE(UNIX_DOMAIN_SOCKETS) > + * Platform/CoreIPC/ArgumentEncoder.cpp: r=me with change HAVE to USE. Please fix it before landing. Landed in http://trac.webkit.org/changeset/86574 Build still busted, re-opening Created attachment 93663 [details] try 2: build fix for Symbian buildbot Balazs had moved some of key QT||GTK defines to UNIX_DOMAIN_SOCKET guards, so I was caught off guard. My bad. My intention was to land Symbian parts in separate Bug 55875 (Shared Memory) and Bug 55877 (Core IPC and Process launching) In any case, here is a somewhat hacky middle ground to keep Symbian bot green until I re-baseline the Core IPC patch in Bug 55877 and get it landed. Comment on attachment 93663 [details]
try 2: build fix for Symbian buildbot
It is a little bit ugly workaround, but rs=me until the real fix landed.
I landed it manually after I removed the unnecessarz trailing whitespaces: http://trac.webkit.org/changeset/86585 |