Bug 60886

Summary:

Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aroben: review+

Description Anders Carlsson 2011-05-16 08:05:12 PDT

Add the ability for a plug-in controller to short-circuit calls to NPN_Invoke

Comment 1 Anders Carlsson 2011-05-16 08:08:55 PDT

Created attachment 93643 [details]
Patch

Comment 2 Adam Roben (:aroben) 2011-05-16 08:10:57 PDT

Comment on attachment 93643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93643&action=review

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:284
> +bool PluginControllerProxy::tryToShortCircuitInvoke(NPObject*, NPIdentifier methodName, const NPVariant* arguments, uint32_t argumentCount, NPVariant* result)

Will these unused variables be a problem?

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:543
> +bool PluginControllerProxy::tryToShortCircuitEvaluate(NPObject* npObject, const String& scriptString, NPVariant* result)

Will these unused variables be a problem?

Comment 3 Anders Carlsson 2011-05-16 08:11:51 PDT

Committed r86573: <http://trac.webkit.org/changeset/86573>