Bug 60876
| Summary: | commit-queue does not accept new reviewers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Patrick R. Gansterer
see bug 59905 (morrita is a reviewer, but cq does not accept the reviewed patch)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
Here's what the bot says:
[[
- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
]]
Did you try those things?
Patrick R. Gansterer
(In reply to comment #1)
> Here's what the bot says:
>
> [[
> - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
> ]]
>
> Did you try those things?
I can read. :)
See http://trac.webkit.org/changeset/86210/trunk/Tools/Scripts/webkitpy/common/config/committers.py.
The change is older than 5 days.
Adam Barth
Five days... That does seem like a long time.
Eric Seidel (no email)
Maybe the feeder-queue got started without the wrapper script? Adam?
The feeder-queue is the one who deals with rejects these days.
Adam Barth
The feeder queue was blocked from updating its working copy because of its dependency on git.webkit.org, which is unreliable.
Eric Seidel (no email)
We believe this to be resolved. Please re-open if you disagree. :)