Bug 60873

Summary:

[Qt] QtPlatformPlugin create methods should use PassOwnPtr

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebKit Qt

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Adam Barth

Reported 2011-05-16 00:05:15 PDT

The "create" methods of QtPlatformPlugin allocate memory and pass ownership of the created object. Therefore, they should return PassOwnPtrs instead of raw pointers. That would let use get rid a bunch of manual calls to delete.

Attachments
Patch (15.65 KB, patch) 2011-05-16 00:23 PDT, Adam Barth	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-05-16 00:23:38 PDT

Created attachment 93617 [details] Patch

Adam Barth

Comment 2 2011-05-16 00:24:06 PDT

Committed r86537: <http://trac.webkit.org/changeset/86537>

Note You need to log in before you can comment on or make changes to this bug.