Bug 60873

Summary:

[Qt] QtPlatformPlugin create methods should use PassOwnPtr

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

WebKit Qt

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2011-05-16 00:05:15 PDT

The "create" methods of QtPlatformPlugin allocate memory and pass ownership of the created object.  Therefore, they should return PassOwnPtrs instead of raw pointers.  That would let use get rid a bunch of manual calls to delete.

Comment 1 Adam Barth 2011-05-16 00:23:38 PDT

Created attachment 93617 [details]
Patch

Comment 2 Adam Barth 2011-05-16 00:24:06 PDT

Committed r86537: <http://trac.webkit.org/changeset/86537>