Bug 60859

Summary: Make API tester more gtest friendly
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch levin: review+

Sam Weinig
Reported 2011-05-15 14:50:38 PDT
Make API tester more gtest friendly
Attachments
Patch (11.46 KB, patch)
2011-05-15 14:56 PDT, Sam Weinig 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-05-15 14:56:16 PDT
Created attachment 93590 [details] Patch
Sam Weinig
Comment 2 2011-05-15 14:59:09 PDT
With this patch, the output of run-api-tests is the standard gtest output (which I am not particularly fond of, but that is neither here nor there) and you can easily pass gtest command line arguments to the tool just by passing them on the command line (eg. run-api-tests --gtest_output="xml"). This gives us a nicer place to improve from.
David Levin
Comment 3 2011-05-15 15:38:39 PDT
Comment on attachment 93590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93590&action=review Thanks! > Tools/Scripts/run-api-tests:94 > + $childOut = ">&STDOUT"; You could even move out out of the unless/else, since it is now common between the two clauses.
Sam Weinig
Comment 4 2011-05-15 15:41:26 PDT
Committed r86511: <http://trac.webkit.org/changeset/86511>
Note You need to log in before you can comment on or make changes to this bug.