Bug 60813

Summary:

Web Inspector: node selection is slow in the Elements panel.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, mrobinson, ojan, pfeldman, pmuellr, rik, rniwa, sam, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

61729, 62216

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Suggested solution	yurys: review-, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-03	none
[PATCH] Attempt to fix tests failing on cr-linux	none
[PATCH] Fixed inspector/styles/styles-update-from-js.html test to avoid the double-callback-hit workaround	yurys: review+
[PATCH] Tentatively fixed inspector test failures on Chromium	none
Patch	yurys: review+

Description Pavel Feldman 2011-05-13 16:11:00 PDT

- Open a large site with many nested nodes / tables
- Press and hold Up or Down key for several seconds

inspector is not catching up with the load.

We should
1) speed up styles processing
2) either delay style sidebar update or make it not update until the arrow key is released.

Comment 1 Alexander Pavlov (apavlov) 2011-05-25 10:10:00 PDT

Created attachment 94801 [details]
[PATCH] Suggested solution

Comment 2 WebKit Review Bot 2011-05-25 10:53:35 PDT

Comment on attachment 94801 [details]
[PATCH] Suggested solution

Attachment 94801 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8729927

New failing tests:
inspector/styles/styles-iframe.html
inspector/styles/styles-url-linkify.html
inspector/elements/elements-panel-styles.html
http/tests/inspector/inspect-iframe-from-different-domain.html

Comment 3 WebKit Review Bot 2011-05-25 10:53:41 PDT

Created attachment 94809 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Comment 4 Yury Semikhatsky 2011-05-26 06:18:43 PDT

Comment on attachment 94801 [details]
[PATCH] Suggested solution

View in context: https://bugs.webkit.org/attachment.cgi?id=94801&action=review

Chromium tests failed, r- for now.

> LayoutTests/inspector/styles/styles-update-from-js.html:51
>                      next();

Why is this callback different from the one in testSetStyleAttribute ?

Comment 5 Alexander Pavlov (apavlov) 2011-05-27 10:06:36 PDT

Created attachment 95186 [details]
[PATCH] Attempt to fix tests failing on cr-linux

Comment 6 Alexander Pavlov (apavlov) 2011-05-30 05:50:20 PDT

Created attachment 95340 [details]
[PATCH] Fixed inspector/styles/styles-update-from-js.html test to avoid the double-callback-hit workaround

Comment 7 Yury Semikhatsky 2011-05-30 06:16:34 PDT

Comment on attachment 95340 [details]
[PATCH] Fixed inspector/styles/styles-update-from-js.html test to avoid the double-callback-hit workaround

View in context: https://bugs.webkit.org/attachment.cgi?id=95340&action=review

> LayoutTests/inspector/styles/styles-update-from-js.html:5
> +<script src="../../http/tests/inspector/console-test.js"></script>

Is it really needed?

Comment 8 Alexander Pavlov (apavlov) 2011-05-30 06:51:17 PDT

Committed r87683: <http://trac.webkit.org/changeset/87683>

Comment 9 Alexander Pavlov (apavlov) 2011-05-30 08:05:44 PDT

Rolled out in r87686 (breaks inspector tests on Chromium)

Comment 10 Alexander Pavlov (apavlov) 2011-06-07 06:22:58 PDT

Created attachment 96234 [details]
[PATCH] Tentatively fixed inspector test failures on Chromium

Comment 11 Alexander Pavlov (apavlov) 2011-06-07 08:35:00 PDT

Committed r88238: <http://trac.webkit.org/changeset/88238>

Comment 12 Alexander Pavlov (apavlov) 2011-06-08 04:52:58 PDT

Committed r88337: <http://trac.webkit.org/changeset/88337>

Comment 13 Ryosuke Niwa 2011-06-10 22:58:56 PDT

A test added by this patch is failing on GTK:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r88596%20(14594)/results.html

 Modified cssText
-<div id="container" style="color: rgb(192, 255, 238); "></div>
+<div id="container" style="color: #daC0DE; border: 1px solid black;"></div>
 [expanded] element.style { ()
 color: #C0FFEE;

Comment 14 Pavel Feldman 2011-06-27 01:31:05 PDT

Rolled out as r88337.

Comment 15 Pavel Feldman 2011-06-27 01:34:12 PDT

Created attachment 98680 [details]
Patch

Comment 16 Pavel Feldman 2011-06-27 01:36:12 PDT

Committed r89806: <http://trac.webkit.org/changeset/89806>