Bug 60811

Summary: Web Inspector: [REGRESSION] Completion while on a breakpoint is not working.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Pavel Feldman
Reported 2011-05-13 15:16:39 PDT
I thought we had a test for this one. Surprised it does not work.
Attachments
Patch (8.70 KB, patch)
2011-05-18 07:24 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (9.97 KB, patch)
2011-05-18 08:28 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (10.00 KB, patch)
2011-05-18 08:33 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-05-18 07:24:09 PDT
Created attachment 93910 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2011-05-18 07:28:14 PDT
Comment on attachment 93910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:378 > + selectedCallFrameVariables: function() Any reason for this not being a getter?
Yury Semikhatsky
Comment 3 2011-05-18 07:45:01 PDT
Comment on attachment 93910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review > LayoutTests/inspector/debugger/debugger-completions-on-call-frame.html:30 > + InspectorTest.addResult(golden[i]); Would be better to addResult("FAIL") in case of missing property. > Source/WebCore/inspector/InjectedScriptSource.js:484 > + for (var name in scopeChain[i]) This will be too slow for global scope. > Source/WebCore/inspector/InjectedScriptSource.js:497 > + for (var name in scopeVariableNames) I'd rather resurrect the command that allowed to quickly request all completions.
Pavel Feldman
Comment 4 2011-05-18 08:28:18 PDT
Created attachment 93918 [details] Patch
Pavel Feldman
Comment 5 2011-05-18 08:33:54 PDT
Created attachment 93920 [details] Patch
Pavel Feldman
Comment 6 2011-05-18 08:53:09 PDT
Comment on attachment 93920 [details] Patch Clearing flags on attachment: 93920 Committed r86768: <http://trac.webkit.org/changeset/86768>
Pavel Feldman
Comment 7 2011-05-18 08:53:18 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2011-05-19 11:53:18 PDT
<rdar://problem/9470349>
Note You need to log in before you can comment on or make changes to this bug.