| Summary: | Web Inspector: [REGRESSION] Completion while on a breakpoint is not working. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Pavel Feldman
2011-05-13 15:16:39 PDT
Created attachment 93910 [details]
Patch
Comment on attachment 93910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:378 > + selectedCallFrameVariables: function() Any reason for this not being a getter? Comment on attachment 93910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93910&action=review > LayoutTests/inspector/debugger/debugger-completions-on-call-frame.html:30 > + InspectorTest.addResult(golden[i]); Would be better to addResult("FAIL") in case of missing property. > Source/WebCore/inspector/InjectedScriptSource.js:484 > + for (var name in scopeChain[i]) This will be too slow for global scope. > Source/WebCore/inspector/InjectedScriptSource.js:497 > + for (var name in scopeVariableNames) I'd rather resurrect the command that allowed to quickly request all completions. Created attachment 93918 [details]
Patch
Created attachment 93920 [details]
Patch
Comment on attachment 93920 [details] Patch Clearing flags on attachment: 93920 Committed r86768: <http://trac.webkit.org/changeset/86768> All reviewed patches have been landed. Closing bug. |