|Summary:||Switch controlClipRect to use IntPoint|
|Product:||WebKit||Reporter:||Levi Weintraub <leviw>|
|Component:||Layout and Rendering||Assignee:||Levi Weintraub <leviw>|
|Severity:||Normal||CC:||darin, eae, eric, simon.fraser|
|Version:||528+ (Nightly build)|
|Bug Depends on:||61390|
Description Levi Weintraub 2011-05-13 14:41:07 PDT
Ongoing removal of tx/ty.
Comment 1 Levi Weintraub 2011-05-24 12:16:55 PDT
*** Bug 61383 has been marked as a duplicate of this bug. ***
Comment 3 Levi Weintraub 2011-05-24 12:33:59 PDT
Comment on attachment 94665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94665&action=review > Source/WebCore/rendering/RenderListBox.cpp:694 > + clipRect.move(additionalOffset.x(), additionalOffset.y()); It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point?
Comment 4 Emil A Eklund 2011-05-24 12:51:30 PDT
> It's a bit strange, but perhaps we should consider a flavor of IntRect::move that takes a point? I would support that, there's a lot of code in both the painting and the hit testing code that uses coordinates interchangeably as points and offsets. Being able to move a rect by a point would make it much easier to clean up that code without having to do a lot of conversions.
Comment 5 Levi Weintraub 2011-05-24 13:14:12 PDT
Comment on attachment 94665 [details] Patch Cool. I'm going to hold back on this and make it dependent on such a change.
Comment 7 Eric Seidel (no email) 2011-05-26 15:03:17 PDT
Comment on attachment 94802 [details] Patch This whole size vs. point mess is super-confusing.