Bug 60777

Summary: GTK WebFontInfo should not destroy a NULL FcPattern
Product: WebKit Reporter: Brett Wilson (Google) <brettw>
Component: WebKit APIAssignee: Brett Wilson (Google) <brettw>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Patch abarth: review+

Brett Wilson (Google)
Reported 2011-05-13 09:25:43 PDT
WebFontInfo returns early if there is no match, but it still tries to do FcPatternDestroy on the NULL pointer, which causes a crash.
Attachments
Patch (1.20 KB, patch)
2011-05-13 09:46 PDT, Brett Wilson (Google) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brett Wilson (Google)
Comment 1 2011-05-13 09:46:14 PDT
Created attachment 93469 [details] Patch
Adam Barth
Comment 2 2011-05-13 09:50:18 PDT
Comment on attachment 93469 [details] Patch I should beat you up for a test.
Brett Wilson (Google)
Comment 3 2011-05-13 09:53:45 PDT
Re no tests: I don't know how to repro this in a test. I've only seen this happen when there's a problem with the sandbox. I think it will also happen if FontConfig's config files are missing or messed up. It doesn't seem to happen in a normal environment.
Brett Wilson (Google)
Comment 4 2011-05-13 09:56:36 PDT
Fixed in r86439
Note You need to log in before you can comment on or make changes to this bug.