Summary: | Source/WebCore/html/HTMLFrameElementBase.cpp contains unecessary includes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | arno. <a.renevier> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, gustavo, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
arno.
2011-05-13 09:10:20 PDT
Created attachment 93465 [details]
patch v1
I checked included files, and removed those who looked unused. In order to build webkit, I had to include back SubFrameLoader.h and RenderPart.h. They were probably included by some of the removed includes
Comment on attachment 93465 [details] patch v1 Attachment 93465 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8693220 Comment on attachment 93465 [details] patch v1 Attachment 93465 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8695153 Comment on attachment 93465 [details] patch v1 Attachment 93465 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8693230 Created attachment 93477 [details]
patch v1.1
I probably need to let FrameLoader.h
Comment on attachment 93477 [details] patch v1.1 Rejecting attachment 93477 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'la..." exit_code: 2 Last 500 characters of output: .org/WebKit ff67c13..aa00ad0 master -> origin/master M Source/WebKit2/ChangeLog M Source/WebKit2/UIProcess/mac/TextCheckerMac.mm r86497 = 3e84409c598e09da7b74f2e08d0a2685f245c2f5 (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/bridge/qt/qt_runtime.cpp M Source/WebCore/bridge/qt/qt_runtime.h r86498 = aa00ad0c35bfe0bda94a6e7700e12142fcb99ae7 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded new_master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8698438 Comment on attachment 93477 [details] patch v1.1 View in context: https://bugs.webkit.org/attachment.cgi?id=93477&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This line is preventing the patch from landing. You should replace this line with a sentence about how you're not changing functionality. Created attachment 93576 [details]
patch v1.2
Comment on attachment 93576 [details]
patch v1.2
OK.
Comment on attachment 93576 [details] patch v1.2 Clearing flags on attachment: 93576 Committed r86503: <http://trac.webkit.org/changeset/86503> All reviewed patches have been landed. Closing bug. |