Bug 60754

Summary: [EFL] Remove EAPI macro from functions definition
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, gyuyoung.kim, kenneth, lucas.de.marchi, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
patch
tonikitoo: review+, tonikitoo: commit-queue-
updated changelog
gyuyoung.kim: commit-queue-
updated changelog none

Description Grzegorz Czajkowski 2011-05-13 01:59:25 PDT 
Generally the macro is used in header files only. This patch removes it from definitions.
Comment 1 Grzegorz Czajkowski 2011-05-13 02:13:44 PDT 
Created attachment 93418 [details]
patch
Comment 2 Gyuyoung Kim 2011-05-13 02:26:02 PDT 
LGTM. Informal r+.
Comment 3 Lucas De Marchi 2011-05-13 05:32:48 PDT 
Comment on attachment 93418 [details]
patch

LGTM too.
Comment 4 Antonio Gomes 2011-05-13 06:30:45 PDT 
Comment on attachment 93418 [details]
patch

You should say WHY you are removing it in the ChangeLog
Comment 5 Grzegorz Czajkowski 2011-05-13 06:49:39 PDT 
Created attachment 93444 [details]
updated changelog
Comment 6 Gyuyoung Kim 2011-05-13 20:36:08 PDT 
Comment on attachment 93444 [details]
updated changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=93444&action=review

> Source/WebKit/efl/ChangeLog:3
> +

Please remove blank line.

> Source/WebKit/efl/ChangeLog:4
> +        Reviewed by Antonio Gomes.

Please add blank line to here
Comment 7 Grzegorz Czajkowski 2011-05-15 23:24:47 PDT 
Created attachment 93612 [details]
updated changelog

Fixed Changelog file.
Comment 8 Antonio Gomes 2011-05-16 06:38:12 PDT 
Comment on attachment 93612 [details]
updated changelog

thanks!
Comment 9 WebKit Commit Bot 2011-05-16 09:05:59 PDT 
Comment on attachment 93612 [details]
updated changelog

Clearing flags on attachment: 93612

Committed r86576: <http://trac.webkit.org/changeset/86576>
Comment 10 WebKit Commit Bot 2011-05-16 09:06:04 PDT 
All reviewed patches have been landed.  Closing bug.