Bug 60748

Summary:

Prune #includes from FrameView.h (Part 2)

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit.review.bot: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	andersca: review+

Sam Weinig

Reported 2011-05-12 20:20:36 PDT

Prune #includes from FrameView.h (Part 2)

Attachments
Patch (29.69 KB, patch) 2011-05-12 20:24 PDT, Sam Weinig	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch (31.16 KB, patch) 2011-05-12 20:52 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (36.62 KB, patch) 2011-05-12 23:58 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (40.17 KB, patch) 2011-05-13 10:01 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (40.65 KB, patch) 2011-05-13 11:00 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (41.29 KB, patch) 2011-05-13 11:44 PDT, Sam Weinig	andersca: review+	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2011-05-12 20:24:37 PDT

Created attachment 93395 [details] Patch

Sam Weinig

Comment 2 2011-05-12 20:25:12 PDT

Putting up patch to let the bots attack it.

Collabora GTK+ EWS bot

Comment 3 2011-05-12 20:36:38 PDT

Comment on attachment 93395 [details] Patch Attachment 93395 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8691784

Early Warning System Bot

Comment 4 2011-05-12 20:37:00 PDT

Comment on attachment 93395 [details] Patch Attachment 93395 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8686993

WebKit Review Bot

Comment 5 2011-05-12 20:43:34 PDT

Comment on attachment 93395 [details] Patch Attachment 93395 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8688946

Sam Weinig

Comment 6 2011-05-12 20:52:02 PDT

Created attachment 93396 [details] Patch

Early Warning System Bot

Comment 7 2011-05-12 21:04:45 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8688955

WebKit Review Bot

Comment 8 2011-05-12 21:10:39 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8687918

Gustavo Noronha (kov)

Comment 9 2011-05-12 21:17:10 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8689933

WebKit Review Bot

Comment 10 2011-05-12 21:28:34 PDT

Comment on attachment 93395 [details] Patch Attachment 93395 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8693046

WebKit Review Bot

Comment 11 2011-05-12 22:23:40 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8685999

WebKit Review Bot

Comment 12 2011-05-12 22:58:58 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8688994

Gyuyoung Kim

Comment 13 2011-05-12 23:03:34 PDT

Comment on attachment 93396 [details] Patch Attachment 93396 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8688997

Sam Weinig

Comment 14 2011-05-12 23:58:53 PDT

Created attachment 93408 [details] Patch

WebKit Review Bot

Comment 15 2011-05-13 00:01:25 PDT

Attachment 93408 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/win/FrameCGWin.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebCore/page/chromium/FrameChromium.cpp:31: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 52 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gustavo Noronha (kov)

Comment 16 2011-05-13 00:11:30 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8658013

Early Warning System Bot

Comment 17 2011-05-13 00:11:36 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8680021

Gyuyoung Kim

Comment 18 2011-05-13 00:18:29 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/8694054

WebKit Review Bot

Comment 19 2011-05-13 00:20:17 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8691826

WebKit Review Bot

Comment 20 2011-05-13 01:01:27 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8694070

WebKit Review Bot

Comment 21 2011-05-13 02:05:13 PDT

Comment on attachment 93408 [details] Patch Attachment 93408 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8687972

Sam Weinig

Comment 22 2011-05-13 10:01:58 PDT

Created attachment 93472 [details] Patch

WebKit Review Bot

Comment 23 2011-05-13 10:04:41 PDT

Attachment 93472 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/win/FrameCGWin.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 58 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 24 2011-05-13 10:29:06 PDT

Comment on attachment 93472 [details] Patch Attachment 93472 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8700053

Sam Weinig

Comment 25 2011-05-13 11:00:18 PDT

Created attachment 93483 [details] Patch

WebKit Review Bot

Comment 26 2011-05-13 11:02:38 PDT

Attachment 93483 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/win/FrameCGWin.cpp:32: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 59 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 27 2011-05-13 11:40:06 PDT

Comment on attachment 93483 [details] Patch Attachment 93483 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8695183

Sam Weinig

Comment 28 2011-05-13 11:44:36 PDT

Created attachment 93486 [details] Patch

WebKit Review Bot

Comment 29 2011-05-13 11:46:48 PDT

Attachment 93486 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/page/win/FrameCGWin.cpp:30: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/qt/Api/qgraphicswebview.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/Api/qgraphicswebview.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 60 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 30 2011-05-13 12:09:18 PDT

Committed r86451: <http://trac.webkit.org/changeset/86451>

Note You need to log in before you can comment on or make changes to this bug.