Bug 60718

Summary: Switch paintOutline to use IntRect
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eae, eric, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60318    
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2011-05-12 12:31:56 PDT
It currently takes four ints representing a rect.
Attachments
Patch (9.72 KB, patch)
2011-05-12 15:27 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (9.85 KB, patch)
2011-05-12 16:41 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-05-12 15:27:43 PDT
Created attachment 93356 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-05-12 15:30:11 PDT
Comment on attachment 93356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93356&action=review > Source/WebCore/rendering/RenderObject.h:795 > + void paintOutline(GraphicsContext*, IntRect); const IntRect& please.
Levi Weintraub
Comment 3 2011-05-12 16:41:50 PDT
Created attachment 93366 [details] Patch
Levi Weintraub
Comment 4 2011-05-12 16:59:57 PDT
Thanks for the review!
Levi Weintraub
Comment 5 2011-05-12 17:05:16 PDT
Comment on attachment 93366 [details] Patch Clearing flags on attachment: 93366 Committed r86400: <http://trac.webkit.org/changeset/86400>
Levi Weintraub
Comment 6 2011-05-12 17:05:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.