Bug 60715

Summary:

[Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified

Product:

WebKit

Reporter:

Ramakrishna Sakamuri <ramakrishna.sakamuri>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, laszlo.gombos, ossy, ramakrishna.sakamuri, webkit.review.bot

Priority:

Keywords:

EasyFix, LayoutTestFailure, Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
removed the passed test from Qt skipped list	benjamin: review-, benjamin: commit-queue-
updated patch/changelog submited	none
fixed tab issue in previous patch submited	none

Ramakrishna Sakamuri

Reported 2011-05-12 11:36:27 PDT

These four storage layout tests are currently listed in skipped list for Qt platform but are passing on Qt-Linux. LayoutTests/storage/database-lock-after-reload.html LayoutTests/storage/empty-statement.html LayoutTests/storage/execute-sql-args.html LayoutTests/storage/hash-change-with-xhr.html Platform details: Linux desktop on Ubuntu 10.04 Linux version 2.6.32-31-generic Qt 4.7.2 WebKit version r86351 I will submit a patch for the updated skip list.

Attachments
removed the passed test from Qt skipped list (1.24 KB, patch) 2011-05-12 12:06 PDT, Ramakrishna Sakamuri	benjamin: review- benjamin: commit-queue-	Details Formatted Diff Diff
updated patch/changelog submited (1.22 KB, patch) 2011-05-16 11:59 PDT, Ramakrishna Sakamuri	no flags	Details Formatted Diff Diff
fixed tab issue in previous patch submited (1.24 KB, patch) 2011-05-17 09:53 PDT, Ramakrishna Sakamuri	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ramakrishna Sakamuri

Comment 1 2011-05-12 12:06:13 PDT

Created attachment 93322 [details] removed the passed test from Qt skipped list

Benjamin Poulain

Comment 2 2011-05-13 04:53:17 PDT

Comment on attachment 93322 [details] removed the passed test from Qt skipped list View in context: https://bugs.webkit.org/attachment.cgi?id=93322&action=review There is something very weird with your patch. The diff does not make much sense. > LayoutTests/ChangeLog:5 > + [Qt] [Qt] 4 of the skipped storage layout tests pass on Qt Linux - skip list to be modified [Qt] [Qt] ?

Ramakrishna Sakamuri

Comment 3 2011-05-16 11:59:47 PDT

Created attachment 93681 [details] updated patch/changelog submited

WebKit Review Bot

Comment 4 2011-05-16 13:08:18 PDT

Attachment 93681 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chang Shu

Comment 5 2011-05-17 08:12:36 PDT

Comment on attachment 93681 [details] updated patch/changelog submited View in context: https://bugs.webkit.org/attachment.cgi?id=93681&action=review >> LayoutTests/ChangeLog:6 >> + https://bugs.webkit.org/show_bug.cgi?id=60715 > > Line contains tab character. [whitespace/tab] [5] Please fix the tab issue.

Ramakrishna Sakamuri

Comment 6 2011-05-17 09:53:27 PDT

Created attachment 93782 [details] fixed tab issue in previous patch submited

WebKit Commit Bot

Comment 7 2011-05-17 10:25:26 PDT

Comment on attachment 93782 [details] fixed tab issue in previous patch submited Clearing flags on attachment: 93782 Committed r86682: <http://trac.webkit.org/changeset/86682>

WebKit Commit Bot

Comment 8 2011-05-17 10:25:31 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.