| Summary: | JavaScriptGlue should compile with -Wmissing-prototypes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | JavaScriptCore | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ggaren, oliver, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Attachment 93305 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptGlue/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptGlue/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 93305 [details]
Patch
r=me
*** Bug 60704 has been marked as a duplicate of this bug. *** *** Bug 60705 has been marked as a duplicate of this bug. *** *** Bug 60706 has been marked as a duplicate of this bug. *** Committed r86396: <http://trac.webkit.org/changeset/86396> Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue. |
Created attachment 93305 [details] Patch Reviewed by NOBODY (OOPS!). Enabling -Wmissing-prototypes fixes an Xcode 4 project warning. This also fixes the following compiler warning: JavaScriptGlue/JSUtils.cpp:407:15: error: no previous prototype for function 'getThreadGlobalData' [-Werror,-Wmissing-prototypes,3] JSGlobalData* getThreadGlobalData() ^ * Configurations/Base.xcconfig: Set GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES. * JSUtils.cpp: (getThreadGlobalData): Made static. --- 3 files changed, 21 insertions(+), 2 deletions(-)