Summary: | [Qt] Arm debug build failing on ARMAssembler::debugOffset() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Keith Kyzivat <kamaji> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, ademar, barraclough, commit-queue, eric, jturcotte, laszlo.gombos, ossy, webkit.review.bot | ||||
Priority: | P3 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Keith Kyzivat
2011-05-11 21:39:50 PDT
Created attachment 93243 [details]
Patch
Patch builds without error -- and looks like the right thing to do when comparing to what ARMv7Assembler.h. Comment on attachment 93243 [details]
Patch
LGTM, r=me
Comment on attachment 93243 [details] Patch Clearing flags on attachment: 93243 Committed r86316: <http://trac.webkit.org/changeset/86316> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/86316 might have broken Leopard Intel Debug (Tests) The following tests are not passing: editing/deleting/delete-ligature-001.html editing/deleting/delete-ligature-002.html editing/deleting/delete-ligature-003.html platform/mac/editing/input/devanagari-ligature.html Revision r86316 cherry-picked into qtwebkit-2.2 with commit b718e0e <http://gitorious.org/webkit/qtwebkit/commit/b718e0e> |