Bug 60680

Summary: Disable gc validation in release builds
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: JavaScriptCoreAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aroben: review+

Oliver Hunt
Reported 2011-05-11 17:47:36 PDT
task
Attachments
Patch (1.21 KB, patch)
2011-05-18 11:19 PDT, Oliver Hunt 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-05-11 17:59:00 PDT
We're just leaving this in the build for a few days to help diagnose some crashers.
Oliver Hunt
Comment 2 2011-05-18 11:19:28 PDT
Created attachment 93944 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-05-18 11:27:37 PDT
Comment on attachment 93944 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93944&action=review > Source/JavaScriptCore/wtf/Platform.h:1218 > +#ifndef NDEBUG > +#if !defined(ENABLE_GC_VALIDATION) Could use && instead of two #ifs. Or if you are going to use two #ifs you could make them both #ifndef.
Oliver Hunt
Comment 4 2011-05-18 11:28:57 PDT
Committed r86779: <http://trac.webkit.org/changeset/86779>
Note You need to log in before you can comment on or make changes to this bug.