Bug 60680

Summary:

Disable gc validation in release builds

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

JavaScriptCore

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	aroben: review+

Description Oliver Hunt 2011-05-11 17:47:36 PDT

task

Comment 1 Oliver Hunt 2011-05-11 17:59:00 PDT

We're just leaving this in the build for a few days to help diagnose some crashers.

Comment 2 Oliver Hunt 2011-05-18 11:19:28 PDT

Created attachment 93944 [details]
Patch

Comment 3 Adam Roben (:aroben) 2011-05-18 11:27:37 PDT

Comment on attachment 93944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93944&action=review

> Source/JavaScriptCore/wtf/Platform.h:1218
> +#ifndef NDEBUG
> +#if !defined(ENABLE_GC_VALIDATION)

Could use && instead of two #ifs. Or if you are going to use two #ifs you could make them both #ifndef.

Comment 4 Oliver Hunt 2011-05-18 11:28:57 PDT

Committed r86779: <http://trac.webkit.org/changeset/86779>