Bug 60676 – Enable OwnPtr strict mode in libxml2 XMLDocumentParser

• Component: New Bugs
• Status: RESOLVED DUPLICATE

[Patrick R. Gansterer]

Enable OwnPtr strict mode in libxml2 XMLDocumentParser

[Patrick R. Gansterer]

Created attachment 93217 [details]
Patch

[WebKit Review Bot]

Comment on attachment 93217 [details]
Patch

Attachment 93217 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8691388

[Patrick R. Gansterer]

Created attachment 93222 [details]
Patch

[Adam Barth]

Comment on attachment 93222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93222&action=review

> Source/WebCore/dom/XMLDocumentParserLibxml2.cpp:191
> -        OwnPtr<PendingCallback> callback(m_callbacks.takeFirst());
> +        OwnPtr<PendingCallback> callback = adoptPtr(m_callbacks.takeFirst());

This change is not correct.  m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr.  I thought Maceij wrote a patch that did that?  Maybe he added the ability to Deque but didn't change the type in this file?

[Adam Barth]

s/old/hold/

[Patrick R. Gansterer]

(In reply to comment #4)
> This change is not correct.  m_callbacks should old OwnPtrs and takeFirst should return a PassOwnPtr.  I thought Maceij wrote a patch that did that?  Maybe he added the ability to Deque but didn't change the type in this file?

I don't see such code in Dequeue. Do you have an idea when he made this change?

[Adam Barth]

Maybe he never landed it?  We should ask him on irc.

[Patrick R. Gansterer]

*** This bug has been marked as a duplicate of bug 59394 ***