Summary: | Change nodeAtPoint to take IntPoint instead of int x, int y | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Emil A Eklund <eae> | ||||||||
Component: | Layout and Rendering | Assignee: | Emil A Eklund <eae> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, eric, leviw, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 60318 | ||||||||||
Attachments: |
|
Description
Emil A Eklund
2011-05-11 14:42:22 PDT
Woo! Created attachment 93710 [details]
Patch
I tried to keep this as small as I could, more clean up and changing functions called by nodeAtPoint will follow in separate patches. I realize that the name pointInContainer might not be entirely correct but it was the best I could come up with. If you can think of a better name please do tell. Comment on attachment 93710 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93710&action=review > Source/WebCore/rendering/RenderBlock.cpp:3902 > + tx += x(); > + ty += y(); I don't like it when methods change parameter values. Maybe a local IntSize localOffset(tx + x(), ty + y())? Comment on attachment 93710 [details]
Patch
LGTM. Please respond to smfr before landing of course.
Created attachment 93715 [details]
Patch
> I don't like it when methods change parameter values. Maybe a local IntSize localOffset(tx + x(), ty + y())?
That's a good idea. Made the change you suggested.
Please take another look.
Comment on attachment 93715 [details]
Patch
still LGTM.
Created attachment 93788 [details]
Patch for landing
Comment on attachment 93788 [details] Patch for landing Rejecting attachment 93788 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8709232 Comment on attachment 93788 [details] Patch for landing Clearing flags on attachment: 93788 Committed r86705: <http://trac.webkit.org/changeset/86705> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 93788 [details]: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. |