Bug 60651

Summary: Teach validate-committer-lists how to validate committers bugzilla_email()
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2011-05-11 13:26:34 PDT
Teach validate-committer-lists how to validate committers bugzilla_email()
Attachments
Patch (10.09 KB, patch)
2011-05-11 13:27 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (10.61 KB, patch)
2011-05-11 13:42 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.03 KB, patch)
2011-05-11 13:57 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-05-11 13:27:24 PDT
Created attachment 93165 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-11 13:32:48 PDT
Comment on attachment 93165 [details] Patch Found a bug, new patch coming.
Eric Seidel (no email)
Comment 3 2011-05-11 13:42:50 PDT
Created attachment 93174 [details] Patch
David Levin
Comment 4 2011-05-11 13:52:12 PDT
Comment on attachment 93174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review You could cq+ it. Depends on how you feel about the typo. > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195 > + # This only works if your account has edituser privilages. typo: privileges
Eric Seidel (no email)
Comment 5 2011-05-11 13:56:43 PDT
(In reply to comment #4) > (From update of attachment 93174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review > > You could cq+ it. Depends on how you feel about the typo. > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195 > > + # This only works if your account has edituser privilages. > > typo: privileges Turns out it was spelled wrong in a second place! The message that the commit-queue spams to bugs when users don't have cq privileges. I guess I never knew how to spell the word. :(
Eric Seidel (no email)
Comment 6 2011-05-11 13:57:22 PDT
Created attachment 93179 [details] Patch for landing
Eric Seidel (no email)
Comment 7 2011-05-11 13:57:39 PDT
Thankfully we have apply-from-bug and land-safely, so fixing typos is easy. :)
WebKit Commit Bot
Comment 8 2011-05-11 17:05:00 PDT
Comment on attachment 93179 [details] Patch for landing Clearing flags on attachment: 93179 Committed r86288: <http://trac.webkit.org/changeset/86288>
WebKit Commit Bot
Comment 9 2011-05-11 17:05:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.