Summary: | Teach validate-committer-lists how to validate committers bugzilla_email() | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, levin | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-05-11 13:26:34 PDT
Created attachment 93165 [details]
Patch
Comment on attachment 93165 [details]
Patch
Found a bug, new patch coming.
Created attachment 93174 [details]
Patch
Comment on attachment 93174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review You could cq+ it. Depends on how you feel about the typo. > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195 > + # This only works if your account has edituser privilages. typo: privileges (In reply to comment #4) > (From update of attachment 93174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=93174&action=review > > You could cq+ it. Depends on how you feel about the typo. > > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:195 > > + # This only works if your account has edituser privilages. > > typo: privileges Turns out it was spelled wrong in a second place! The message that the commit-queue spams to bugs when users don't have cq privileges. I guess I never knew how to spell the word. :( Created attachment 93179 [details]
Patch for landing
Thankfully we have apply-from-bug and land-safely, so fixing typos is easy. :) Comment on attachment 93179 [details] Patch for landing Clearing flags on attachment: 93179 Committed r86288: <http://trac.webkit.org/changeset/86288> All reviewed patches have been landed. Closing bug. |