| Summary: | [CMAKE] Move EFL-specific file to CMakeListsEfl.txt | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||
| Component: | New Bugs | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, gyuyoung.kim, kenneth, paroga, tonikitoo | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Lucas De Marchi
2011-05-11 11:20:57 PDT
Created attachment 93150 [details]
Patch
Comment on attachment 93150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93150&action=review > Source/WebCore/CMakeLists.txt:1958 > +SET(WebCore_LIBRARIES ${JavaScriptCore_LIBRARY_NAME}) > +SET(WebCore_LINK_FLAGS "") > +INCLUDE_IF_EXISTS(${WEBCORE_DIR}/CMakeLists${PORT}.txt) looks unrelated, but OK :) Comment on attachment 93150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=93150&action=review Thanks. >> Source/WebCore/CMakeLists.txt:1958 >> +INCLUDE_IF_EXISTS(${WEBCORE_DIR}/CMakeLists${PORT}.txt) > > looks unrelated, but OK :) It's related... it's the same code as below, but moved to this place as I said in the changelog. The commit-queue encountered the following flaky tests while processing attachment 93150 [details]: inspector/debugger/debugger-scripts.html bug 59921 (authors: pfeldman@chromium.org and podivilov@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 93150 [details] Patch Clearing flags on attachment: 93150 Committed r86283: <http://trac.webkit.org/changeset/86283> All reviewed patches have been landed. Closing bug. |