| Summary: | [WK2] Skip fast/events/tabindex-focus-blur-all.html for WebKit2 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||||
| Component: | Tools / Tests | Assignee: | Chang Shu <cshu> | ||||||
| Status: | RESOLVED WONTFIX | ||||||||
| Severity: | Normal | CC: | darin, enrica, eric, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 58327 | ||||||||
| Attachments: |
|
||||||||
|
Description
Chang Shu
2011-05-11 11:14:36 PDT
Created attachment 93148 [details]
fix patch
Comment on attachment 93148 [details] fix patch Rejecting attachment 93148 [details] from review queue. cshu@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 93148 [details]
fix patch
I accidentally put '+' for '?'s. :)
Comment on attachment 93148 [details] fix patch View in context: https://bugs.webkit.org/attachment.cgi?id=93148&action=review [Leopard Intel Debug Tests]? > LayoutTests/platform/mac-wk2/Skipped:1534 > +# [Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513, 83521] [Leopard Intel Debug Tests]? I also observed a crash for wk2 release build and commented on this existing one. Probably I should open a new bug.
> > LayoutTests/platform/mac-wk2/Skipped:1534
> > +# [Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513, 83521]
>
> [Leopard Intel Debug Tests]?
Created attachment 93278 [details]
fix patch 2: follow review
Comment on attachment 93278 [details] fix patch 2: follow review View in context: https://bugs.webkit.org/attachment.cgi?id=93278&action=review > LayoutTests/ChangeLog:9 > + This test appears to pass but it actually crashes internally and takes 20s to finish. > + The crash is logged in bug 60696. Where is this test crashing? I don't see it crashing on waterfall. > > + This test appears to pass but it actually crashes internally and takes 20s to finish. > > + The crash is logged in bug 60696. > > Where is this test crashing? I don't see it crashing on waterfall. I found the problem is shown in the latest results: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r86671%20%2811729%29/fast/events/tabindex-focus-blur-all-stderr.txt This patch is ancient. Comment on attachment 93278 [details]
fix patch 2: follow review
clear flags. the status was set to wont fix already.
|