Bug 60635

Summary: Video track sometimes fails to draw
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Macintosh   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. darin: review+

Description Eric Carlson 2011-05-11 09:42:11 PDT
If HTMLMediaElement replaces the MediaPlayer after its display state has been set to "video", the new media engine has no way to know that it is allowed to display video.

If the display state is reset whenever MediaPlayer is replaced,  the media engine will get the correct state when it is recalculated.

<rdar://problem/9281951>
Comment 1 Eric Carlson 2011-05-11 10:07:42 PDT
Created attachment 93140 [details]
Proposed patch.
Comment 2 Darin Adler 2011-05-11 10:33:19 PDT
Comment on attachment 93140 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=93140&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:713
> +    // Reset display mode to force a recalculation of what to show becuase we are resetting the player.

This misspells because.
Comment 3 Eric Carlson 2011-05-11 10:43:13 PDT
http://trac.webkit.org/changeset/86245
Comment 4 Ademar Reis 2011-06-03 14:10:26 PDT
Revision r86245 cherry-picked into qtwebkit-2.2 with commit 3f5fab4 <http://gitorious.org/webkit/qtwebkit/commit/3f5fab4>