Bug 60631

Summary: WebKit2 doesn't clear the pendingAPIRequestURL on in-page anchor navigation
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit2Assignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations
darin: review+
Added bugzilla bug number to ChangeLog darin: review+

Description John Sullivan 2011-05-11 08:59:26 PDT 
WebKit2 clears the WebPageProxy's pendingAPIRequestURL when a provisional load starts, but does not clear it on an in-page anchor navigation. In-page anchor navigations never cause a provisional load to start, so the pendingAPIRequestURL is never cleared. This causes trouble for clients that test for a pendingAPIRequestURL later.

In Radar as <rdar://problem/9420520>.
Comment 1 John Sullivan 2011-05-11 09:25:18 PDT 
Created attachment 93130 [details]
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations
Comment 2 WebKit Review Bot 2011-05-11 09:27:28 PDT 
Attachment 93130 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2011-05-11 09:30:09 PDT 
Comment on attachment 93130 [details]
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations

Need to include the bugs.webkit.org bug number too.
Comment 4 Darin Adler 2011-05-11 09:30:21 PDT 
Comment on attachment 93130 [details]
Patch to add a call to clearPendingAPIRequestURL for in-page anchor navigations

Bug URL, I mean.
Comment 5 John Sullivan 2011-05-11 09:31:43 PDT 
Created attachment 93133 [details]
Added bugzilla bug number to ChangeLog
Comment 6 John Sullivan 2011-05-11 09:46:12 PDT 
Fixed in r86240.